Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: src/debug/debug.cc

Issue 1423713018: [debugger] Move clearing of optimized code map out of GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_opt-code-map-rework-2
Patch Set: Addressed comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/objects-visiting-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1287 matching lines...) Expand 10 before | Expand all | Expand 10 after
1298 bool Debug::PrepareFunctionForBreakPoints(Handle<SharedFunctionInfo> shared) { 1298 bool Debug::PrepareFunctionForBreakPoints(Handle<SharedFunctionInfo> shared) {
1299 DCHECK(shared->is_compiled()); 1299 DCHECK(shared->is_compiled());
1300 1300
1301 if (isolate_->concurrent_recompilation_enabled()) { 1301 if (isolate_->concurrent_recompilation_enabled()) {
1302 isolate_->optimizing_compile_dispatcher()->Flush(); 1302 isolate_->optimizing_compile_dispatcher()->Flush();
1303 } 1303 }
1304 1304
1305 List<Handle<JSFunction> > functions; 1305 List<Handle<JSFunction> > functions;
1306 List<Handle<JSGeneratorObject> > suspended_generators; 1306 List<Handle<JSGeneratorObject> > suspended_generators;
1307 1307
1308 if (!shared->optimized_code_map()->IsSmi()) { 1308 // Flush all optimized code maps. Note that the below heap iteration does not
1309 shared->ClearOptimizedCodeMap(); 1309 // cover this, because the given function might have been inlined into code
1310 // for which no JSFunction exists.
1311 {
1312 SharedFunctionInfo::Iterator iterator(isolate_);
1313 while (SharedFunctionInfo* shared = iterator.Next()) {
1314 if (!shared->optimized_code_map()->IsSmi()) {
1315 shared->ClearOptimizedCodeMap();
1316 }
1317 }
1310 } 1318 }
1311 1319
1312 // Make sure we abort incremental marking. 1320 // Make sure we abort incremental marking.
1313 isolate_->heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask, 1321 isolate_->heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask,
1314 "prepare for break points"); 1322 "prepare for break points");
1315 1323
1316 { 1324 {
1317 HeapIterator iterator(isolate_->heap()); 1325 HeapIterator iterator(isolate_->heap());
1318 HeapObject* obj; 1326 HeapObject* obj;
1319 bool include_generators = shared->is_generator(); 1327 bool include_generators = shared->is_generator();
(...skipping 1261 matching lines...) Expand 10 before | Expand all | Expand 10 after
2581 } 2589 }
2582 2590
2583 2591
2584 void LockingCommandMessageQueue::Clear() { 2592 void LockingCommandMessageQueue::Clear() {
2585 base::LockGuard<base::Mutex> lock_guard(&mutex_); 2593 base::LockGuard<base::Mutex> lock_guard(&mutex_);
2586 queue_.Clear(); 2594 queue_.Clear();
2587 } 2595 }
2588 2596
2589 } // namespace internal 2597 } // namespace internal
2590 } // namespace v8 2598 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/heap/objects-visiting-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698