Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1423713014: PPC: [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. Port ab84025977fb94bebf7d4d83b874da5a6c1c6293 Also: - Fix big-endian compiler hints BYTE_OFFSET macro. - Clean up PPC code access to compiler hints -- which required some new SharedFunctionInfo fields to encapsulate kCompilerHintsSmiTagSize. Original commit message: The current implementation of classes throws the TypeError at the wrong point, after activating a new context when directly calling a class constructor. According to the spec, the TypeError has to be thrown in the caller context. R=bmeurer@chromium.org, cbruni@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com LOG=N BUG=v8:4428 Committed: https://crrev.com/6413ef4e632e425195beb4ab0ceefe3b308c51e9 Cr-Commit-Position: refs/heads/master@{#31831}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -69 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +3 lines, -18 lines 0 comments Download
M src/objects.h View 1 2 chunks +18 lines, -11 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +18 lines, -15 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +32 lines, -25 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
MTBrandyberry
Contains common-code changes.
5 years, 1 month ago (2015-11-04 19:43:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423713014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423713014/1
5 years, 1 month ago (2015-11-04 19:46:01 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 20:19:06 UTC) #5
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-11-05 02:46:16 UTC) #6
Camillo Bruni
lgtm
5 years, 1 month ago (2015-11-05 11:34:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423713014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423713014/1
5 years, 1 month ago (2015-11-05 14:19:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7476)
5 years, 1 month ago (2015-11-05 14:21:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423713014/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423713014/40001
5 years, 1 month ago (2015-11-05 14:33:42 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-11-05 14:51:42 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 14:51:57 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6413ef4e632e425195beb4ab0ceefe3b308c51e9
Cr-Commit-Position: refs/heads/master@{#31831}

Powered by Google App Engine
This is Rietveld 408576698