Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 1423713005: [MD settings] fix for sync page i18n behavior (Closed)

Created:
5 years, 1 month ago by dschuyler
Modified:
5 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] fix for sync page i18n behavior This is a small fix for the path that includes the i18n behavior (which changed recently). BUG=537405 Committed: https://crrev.com/82b1be5a17d77a329057e48f6c073f103eaf695a Cr-Commit-Position: refs/heads/master@{#355948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/sync_page/sync_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
dschuyler
5 years, 1 month ago (2015-10-23 22:56:21 UTC) #3
stevenjb
lgtm
5 years, 1 month ago (2015-10-23 23:01:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423713005/1
5 years, 1 month ago (2015-10-23 23:04:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/125297)
5 years, 1 month ago (2015-10-23 23:55:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423713005/1
5 years, 1 month ago (2015-10-24 00:52:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-24 01:28:47 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-24 01:29:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82b1be5a17d77a329057e48f6c073f103eaf695a
Cr-Commit-Position: refs/heads/master@{#355948}

Powered by Google App Engine
This is Rietveld 408576698