Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1423703002: Don't drop the floating point part of events when converting types. (Closed)

Created:
5 years, 2 months ago by danakj
Modified:
5 years, 2 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, tdresser+watch_chromium.org, tfarina, dcheng, kalyank, jdduke+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't drop the floating point part of events when converting types. A few places that make an event out of another event use the location() instead of the location_f() which means they drop the floating point part of the original event. R=sadrul, sky BUG=342848 Committed: https://crrev.com/05558ce51d776aee1b12104a2d6aba7971b77442 Cr-Commit-Position: refs/heads/master@{#355682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M ui/aura/window_targeter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/events/gestures/motion_event_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
danakj
5 years, 2 months ago (2015-10-22 21:37:12 UTC) #1
sky
LGTM
5 years, 2 months ago (2015-10-22 23:10:09 UTC) #2
sadrul
lgtm
5 years, 2 months ago (2015-10-22 23:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423703002/1
5 years, 2 months ago (2015-10-22 23:27:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 00:04:43 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 00:05:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05558ce51d776aee1b12104a2d6aba7971b77442
Cr-Commit-Position: refs/heads/master@{#355682}

Powered by Google App Engine
This is Rietveld 408576698