chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix JS. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/media_router_metrics.cc ('k') | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index 081c422cb7bdbb3728e4ed76e978430939730e16..a1139c30e2d238555ca42f24081e3bb00fc1cdf1 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -31,6 +31,7 @@

#include "chrome/browser/extensions/devtools_util.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/media/router/media_router_dialog_controller.h"

+#include "chrome/browser/media/router/media_router_metrics.h"

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"

#include "chrome/browser/password_manager/chrome_password_manager_client.h"

@@ -1730,6 +1731,10 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {

return;

dialog_controller->ShowMediaRouterDialog();

+ media_router::MediaRouterMetrics::RecordMediaRouterDialogOrigin(

+ media_router::CONTEXTUAL_MENU);

break;

}