chrome/browser/resources/media_router/media_router_ui_interface.js - Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/media_router_ui_interface.js

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per pkasting@'s comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/media_router.js ('k') | chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/media_router_ui_interface.js

diff --git a/chrome/browser/resources/media_router/media_router_ui_interface.js b/chrome/browser/resources/media_router/media_router_ui_interface.js

index 74061595b4c86a2f3d5d02b4e35441d5ea9e816a..58460957ce80282a7ffec671111897a95fdb3cd9 100644

--- a/chrome/browser/resources/media_router/media_router_ui_interface.js

+++ b/chrome/browser/resources/media_router/media_router_ui_interface.js

@@ -144,6 +144,15 @@ cr.define('media_router.browserApi', function() {

}

/**

+ * Reports the current number of sinks.

+ *

+ * @param {number} sinkCount

+ */

+ function reportSinkCount(sinkCount) {

+ chrome.send('reportSinkCount', [{sinkCount: sinkCount}]);

imcheng 2015/10/26 17:18:14 Is it possible to just return the sinkCount in the

apacible 2015/10/26 17:52:32 Done.

+ }

+ /**

* Requests data to initialize the WebUI with.

* The data will be returned via media_router.ui.setInitialData.

@@ -167,6 +176,7 @@ cr.define('media_router.browserApi', function() {

actOnIssue: actOnIssue,

closeDialog: closeDialog,

closeRoute: closeRoute,

+ reportSinkCount: reportSinkCount,

requestInitialData: requestInitialData,

requestRoute: requestRoute,

};