chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js - Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per pkasting@'s comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | chrome/browser/resources/media_router/media_router.js » ('j') | chrome/browser/resources/media_router/media_router_ui_interface.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

index ba949c3cad8b0446fc47c20210ee448fd52efa2e..d9636271c0e6cd300ff8d72e2508ebb00f794364 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

@@ -203,9 +203,13 @@ Polymer({

attached: function() {

- // Turn off the spinner after 3 seconds.

+ // Turn off the spinner after 3 seconds, then report the current number of

+ // sinks.

this.async(function() {

this.justOpened_ = false;

+ this.fire('report-sink-count', {

+ sinkCount: this.allSinks.length,

+ });

}, 3000 /* 3 seconds */);