chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc - Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per isherman@'s comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/media_router_action.cc ('K') | « chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.h ('k') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h » ('j') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc

diff --git a/chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc b/chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc

index 9dd1af164329253858c90a82e130ee4ef43478cd..3b4c15f5662b827d50dc3adcdfe181ae625f8429 100644

--- a/chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc

+++ b/chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc

@@ -25,11 +25,15 @@ MediaRouterActionPlatformDelegateViews::

~MediaRouterActionPlatformDelegateViews() {

}

-void MediaRouterActionPlatformDelegateViews::CloseOverflowMenuIfOpen() {

+bool MediaRouterActionPlatformDelegateViews::CloseOverflowMenuIfOpen() {

AppMenuButton* app_menu_button =

BrowserView::GetBrowserViewForBrowser(browser_)

->toolbar()

->app_menu_button();

- if (app_menu_button->IsMenuShowing())

+ if (app_menu_button->IsMenuShowing()) {

Peter Kasting 2015/10/23 23:48:51 Nit: Same comment

apacible 2015/10/24 22:06:28 Done.

app_menu_button->CloseMenu();

+ return true;

+ }

+ return false;

}