Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: chrome/browser/ui/toolbar/media_router_action.cc

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per isherman@'s comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/media_router_action.h" 5 #include "chrome/browser/ui/toolbar/media_router_action.h"
6 6
7 #include "base/metrics/user_metrics.h"
7 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/media/router/issue.h" 9 #include "chrome/browser/media/router/issue.h"
9 #include "chrome/browser/media/router/media_route.h" 10 #include "chrome/browser/media/router/media_route.h"
10 #include "chrome/browser/media/router/media_router.h" 11 #include "chrome/browser/media/router/media_router.h"
11 #include "chrome/browser/media/router/media_router_factory.h" 12 #include "chrome/browser/media/router/media_router_factory.h"
13 #include "chrome/browser/media/router/media_router_metrics.h"
12 #include "chrome/browser/media/router/media_router_mojo_impl.h" 14 #include "chrome/browser/media/router/media_router_mojo_impl.h"
13 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/browser.h" 16 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/tabs/tab_strip_model.h" 17 #include "chrome/browser/ui/tabs/tab_strip_model.h"
16 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h" 18 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
17 #include "chrome/browser/ui/toolbar/media_router_action_platform_delegate.h" 19 #include "chrome/browser/ui/toolbar/media_router_action_platform_delegate.h"
18 #include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h" 20 #include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"
19 #include "chrome/browser/ui/webui/media_router/media_router_dialog_controller_im pl.h" 21 #include "chrome/browser/ui/webui/media_router/media_router_dialog_controller_im pl.h"
20 #include "chrome/grit/generated_resources.h" 22 #include "chrome/grit/generated_resources.h"
21 #include "grit/theme_resources.h" 23 #include "grit/theme_resources.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 125
124 gfx::NativeView MediaRouterAction::GetPopupNativeView() { 126 gfx::NativeView MediaRouterAction::GetPopupNativeView() {
125 return nullptr; 127 return nullptr;
126 } 128 }
127 129
128 ui::MenuModel* MediaRouterAction::GetContextMenu() { 130 ui::MenuModel* MediaRouterAction::GetContextMenu() {
129 return contextual_menu_.menu_model(); 131 return contextual_menu_.menu_model();
130 } 132 }
131 133
132 bool MediaRouterAction::ExecuteAction(bool by_user) { 134 bool MediaRouterAction::ExecuteAction(bool by_user) {
135 base::RecordAction(base::UserMetricsAction("MediaRouter_Icon_Click"));
136
133 GetMediaRouterDialogController()->ShowMediaRouterDialog(); 137 GetMediaRouterDialogController()->ShowMediaRouterDialog();
134 if (GetPlatformDelegate()) 138 if (GetPlatformDelegate()) {
135 GetPlatformDelegate()->CloseOverflowMenuIfOpen(); 139 if (GetPlatformDelegate()->CloseOverflowMenuIfOpen()) {
140 media_router::MediaRouterMetrics::RecordMediaRouterDialogOrigin(
141 media_router::OVERFLOW_MENU);
142 } else {
143 media_router::MediaRouterMetrics::RecordMediaRouterDialogOrigin(
144 media_router::TOOLBAR);
145 }
Peter Kasting 2015/10/23 23:48:51 Nit: Shorter: media_router::MediaRouterMetric
apacible 2015/10/24 22:06:28 Done.
146 }
136 return true; 147 return true;
137 } 148 }
138 149
139 void MediaRouterAction::UpdateState() { 150 void MediaRouterAction::UpdateState() {
140 if (delegate_) 151 if (delegate_)
141 delegate_->UpdateState(); 152 delegate_->UpdateState();
142 } 153 }
143 154
144 bool MediaRouterAction::DisabledClickOpensMenu() const { 155 bool MediaRouterAction::DisabledClickOpensMenu() const {
145 return false; 156 return false;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 if (issue_) { 237 if (issue_) {
227 if (issue_->severity() == media_router::Issue::FATAL) 238 if (issue_->severity() == media_router::Issue::FATAL)
228 return &media_router_error_icon_; 239 return &media_router_error_icon_;
229 if (issue_->severity() == media_router::Issue::WARNING) 240 if (issue_->severity() == media_router::Issue::WARNING)
230 return &media_router_warning_icon_; 241 return &media_router_warning_icon_;
231 } 242 }
232 243
233 return has_local_route_ ? 244 return has_local_route_ ?
234 &media_router_active_icon_ : &media_router_idle_icon_; 245 &media_router_active_icon_ : &media_router_idle_icon_;
235 } 246 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698