[Media Router] Add P1 UMA metrics for Media Router.

chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
+#include "base/metrics/histogram.h"
+#include "base/metrics/histogram_base.h"

[Ilya Sherman, 2015/10/23 20:40:22]

Please replace these with a histogram_macros include.

[apacible, 2015/10/23 22:52:55]

Done.

 #include "base/strings/stringprintf.h"
 #include "chrome/browser/media/router/issue.h"
 #include "chrome/browser/ui/webui/media_router/media_router_ui.h"
 #include "chrome/grit/generated_resources.h"
 #include "extensions/common/constants.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace media_router {
 
 namespace {
 
 const char kHelpPageUrlPrefix[] =
     "https://support.google.com/chromecast/answer/%d";
 
 // Message names.
 const char kRequestInitialData[] = "requestInitialData";
 const char kCreateRoute[] = "requestRoute";
 const char kActOnIssue[] = "actOnIssue";
 const char kCloseRoute[] = "closeRoute";
 const char kCloseDialog[] = "closeDialog";
+const char kReportSinkCount[] = "reportSinkCount";
 
 // JS function names.
 const char kSetInitialData[] = "media_router.ui.setInitialData";
 const char kNotifyRouteCreationTimeout[] =
     "media_router.ui.onNotifyRouteCreationTimeout";
 const char kOnCreateRouteResponseReceived[] =
     "media_router.ui.onCreateRouteResponseReceived";
 const char kSetIssue[] = "media_router.ui.setIssue";
 const char kSetSinkList[] = "media_router.ui.setSinkList";
 const char kSetRouteList[] = "media_router.ui.setRouteList";
@@ skipping 155 matching lines @@
 
 void MediaRouterWebUIMessageHandler::OnCreateRouteResponseReceived(
     const MediaSink::Id& sink_id,
     const MediaRoute* route) {
   DVLOG(2) << "OnCreateRouteResponseReceived";
   if (route) {
     scoped_ptr<base::DictionaryValue> route_value(RouteToValue(*route,
         media_router_ui_->GetRouteProviderExtensionId()));
     web_ui()->CallJavascriptFunction(kOnCreateRouteResponseReceived,
                                      base::StringValue(sink_id), *route_value);
+
+    UMA_HISTOGRAM_BOOLEAN(
+        "MediaRouter.Ui.Action.StartLocalSessionSuccessful", true);
   } else {
     web_ui()->CallJavascriptFunction(kOnCreateRouteResponseReceived,
                                      base::StringValue(sink_id),
                                      *base::Value::CreateNullValue());
+
+    UMA_HISTOGRAM_BOOLEAN(
+        "MediaRouter.Ui.Action.StartLocalSessionSuccessful", false);

[Ilya Sherman, 2015/10/23 20:40:22]

Please record this as UMA_HISTOGRAM_BOOLEAN(..., route);, so that the macro is
only written once for this histogram.

[apacible, 2015/10/23 22:52:55]

Done.

[apacible, 2015/10/26 17:52:32]

Switched back because of these warnings:

e:\b\build\slave\win\build\src\chrome\browser\ui\webui\media_router\media_router_webui_message_handler.cc(214)
: error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\chrome\browser\ui\webui\media_router\media_router_webui_message_handler.cc(214)
: warning C4800: 'const media_router::MediaRoute *' : forcing value to bool
'true' or 'false' (performance warning)

   }
 }
 
 void MediaRouterWebUIMessageHandler::UpdateIssue(const Issue* issue) {
   DVLOG(2) << "UpdateIssue";
   if (issue) {
     scoped_ptr<base::DictionaryValue> issue_val(IssueToValue(*issue));
     web_ui()->CallJavascriptFunction(kSetIssue, *issue_val);
   } else {
     // Clears the issue in the WebUI.
@@ skipping 20 matching lines @@
       base::Bind(&MediaRouterWebUIMessageHandler::OnActOnIssue,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       kCloseRoute,
       base::Bind(&MediaRouterWebUIMessageHandler::OnCloseRoute,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       kCloseDialog,
       base::Bind(&MediaRouterWebUIMessageHandler::OnCloseDialog,
                  base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      kReportSinkCount,
+      base::Bind(&MediaRouterWebUIMessageHandler::OnReportSinkCount,
+                 base::Unretained(this)));
 }
 
 void MediaRouterWebUIMessageHandler::OnRequestInitialData(
     const base::ListValue* args) {
   DVLOG(1) << "OnRequestInitialData";
   base::DictionaryValue initial_data;
 
   // "No Cast devices found?" Chromecast help center page.
   initial_data.SetString("deviceMissingUrl",
       base::StringPrintf(kHelpPageUrlPrefix, 3249268));
@@ skipping 107 matching lines @@
 void MediaRouterWebUIMessageHandler::OnCloseDialog(
     const base::ListValue* args) {
   DVLOG(1) << "OnCloseDialog";
   if (dialog_closing_)
     return;
 
   dialog_closing_ = true;
   media_router_ui_->Close();
 }
 
+void MediaRouterWebUIMessageHandler::OnReportSinkCount(
+    const base::ListValue* args) {
+  DVLOG(1) << "OnReportSinkCount";
+  const base::DictionaryValue* args_dict = nullptr;
+  int sink_count = -1;
+  if (!args->GetDictionary(0, &args_dict) ||
+      !args_dict->GetInteger("sinkCount", &sink_count)) {
+    DVLOG(1) << "Unable to extract args.";
+    return;
+  }
+  UMA_HISTOGRAM_COUNTS_100("MediaRouter.Ui.Device.Count", sink_count);
+}
+
 bool MediaRouterWebUIMessageHandler::ActOnIssueType(
     const IssueAction::Type& action_type,
     const base::DictionaryValue* args) {
   if (action_type == IssueAction::TYPE_LEARN_MORE) {
     std::string learn_more_url = GetLearnMoreUrl(args);
     if (learn_more_url.empty())
       return false;
     scoped_ptr<base::ListValue> open_args(new base::ListValue);
     open_args->AppendString(learn_more_url);
     web_ui()->CallJavascriptFunction(kWindowOpen, *open_args);
     return true;
   } else {
     // Do nothing; no other issue action types require any other action.
     return true;
   }
 }
 
 }  // namespace media_router