Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1423673003: Debugger: correctly break in default constructor. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: correctly break in default constructor. R=rossberg@chromium.org Committed: https://crrev.com/798ce4e463a3e813372d6d85c82c2c02010a8b7a Cr-Commit-Position: refs/heads/master@{#31665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M src/full-codegen/full-codegen.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/es6/debug-break-default-constructor.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 1 month ago (2015-10-29 14:09:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423673003/1
5 years, 1 month ago (2015-10-29 14:15:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 14:38:41 UTC) #5
rossberg
lgtm
5 years, 1 month ago (2015-10-29 16:45:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423673003/1
5 years, 1 month ago (2015-10-29 17:21:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 17:22:48 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 17:22:56 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/798ce4e463a3e813372d6d85c82c2c02010a8b7a
Cr-Commit-Position: refs/heads/master@{#31665}

Powered by Google App Engine
This is Rietveld 408576698