Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8861)

Unified Diff: content/browser/loader/mime_type_resource_handler.cc

Issue 1423663012: Removing x-x509-user-cert mime handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding tests. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/certificate_resource_handler.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/mime_type_resource_handler.cc
diff --git a/content/browser/loader/mime_type_resource_handler.cc b/content/browser/loader/mime_type_resource_handler.cc
index a95490145dbf19010a363f0b8e258fb8cf76625a..3c69c0ad4d2c9f644a7697cdf27652d4ed7e539b 100644
--- a/content/browser/loader/mime_type_resource_handler.cc
+++ b/content/browser/loader/mime_type_resource_handler.cc
@@ -17,7 +17,6 @@
#include "components/mime_util/mime_util.h"
#include "content/browser/download/download_resource_handler.h"
#include "content/browser/download/download_stats.h"
-#include "content/browser/loader/certificate_resource_handler.h"
#include "content/browser/loader/resource_dispatcher_host_impl.h"
#include "content/browser/loader/resource_request_info_impl.h"
#include "content/browser/loader/stream_resource_handler.h"
@@ -341,12 +340,14 @@ bool MimeTypeResourceHandler::SelectNextHandler(bool* defer) {
ResourceRequestInfoImpl* info = GetRequestInfo();
const std::string& mime_type = response_->head.mime_type;
- if (mime_util::IsSupportedCertificateMimeType(mime_type)) {
- // Install certificate file.
- info->set_is_download(true);
- scoped_ptr<ResourceHandler> handler(
- new CertificateResourceHandler(request()));
- return UseAlternateNextHandler(std::move(handler), std::string());
+ // https://crbug.com/568184 - Temporary hack to track servers that aren't
+ // setting Content-Disposition when sending x-x509-user-cert and expecting
+ // the browser to automatically install certificates; this is being
+ // deprecated and will be removed upon full <keygen> removal.
+ if (mime_type == "application/x-x509-user-cert") {
+ UMA_HISTOGRAM_BOOLEAN(
+ "UserCert.ContentDisposition",
+ response_->head.headers->HasHeader("Content-Disposition"));
}
// Allow requests for object/embed tags to be intercepted as streams.
« no previous file with comments | « content/browser/loader/certificate_resource_handler.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698