Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: content/browser/loader/mime_type_resource_handler.cc

Issue 1423663012: Removing x-x509-user-cert mime handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/mime_util/mime_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/mime_type_resource_handler.cc
diff --git a/content/browser/loader/mime_type_resource_handler.cc b/content/browser/loader/mime_type_resource_handler.cc
index 59c2b5310660487b1a0ccdc7f9591da7ebcc14bc..31f700fde327b1a6cb5b5960732af92798dbecb9 100644
--- a/content/browser/loader/mime_type_resource_handler.cc
+++ b/content/browser/loader/mime_type_resource_handler.cc
@@ -12,6 +12,7 @@
#include "base/metrics/histogram.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
#include "base/thread_task_runner_handle.h"
#include "components/mime_util/mime_util.h"
#include "content/browser/download/download_resource_handler.h"
@@ -381,6 +382,10 @@ bool MimeTypeResourceHandler::SelectNextHandler(bool* defer) {
return true;
}
+ scoped_ptr<DownloadSaveInfo> save_info(new DownloadSaveInfo);
+ if (base::ToLowerASCII(mime_type) == "application/x-x509-user-cert")
+ save_info->suggested_name = base::UTF8ToUTF16("user_cert.crt");
mmenke 2015/10/29 15:34:56 Why not put this in GetSuggestedFilename? Also, w
svaldez 2015/10/29 16:32:19 Done.
+
// Install download handler
info->set_is_download(true);
scoped_ptr<ResourceHandler> handler(
@@ -389,7 +394,7 @@ bool MimeTypeResourceHandler::SelectNextHandler(bool* defer) {
true, // is_content_initiated
must_download,
DownloadItem::kInvalidId,
- scoped_ptr<DownloadSaveInfo>(new DownloadSaveInfo()),
+ save_info.Pass(),
DownloadUrlParameters::OnStartedCallback()));
return UseAlternateNextHandler(handler.Pass(), std::string());
}
« no previous file with comments | « components/mime_util/mime_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698