Removing x-x509-user-cert mime handler.

chrome/browser/download/chrome_download_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 440 matching lines @@
   content::WebContents* web_contents = download->GetWebContents();
   Browser* browser =
       web_contents ? chrome::FindBrowserWithWebContents(web_contents) : NULL;
   scoped_ptr<chrome::ScopedTabbedBrowserDisplayer> browser_displayer;
   if (!browser ||
       !browser->CanSupportWindowFeature(Browser::FEATURE_TABSTRIP)) {
     browser_displayer.reset(new chrome::ScopedTabbedBrowserDisplayer(
         profile_, chrome::GetActiveDesktop()));
     browser = browser_displayer->browser();
   }
+
   content::OpenURLParams params(
       net::FilePathToFileURL(download->GetTargetFilePath()),
       content::Referrer(),
       NEW_FOREGROUND_TAB,
       ui::PAGE_TRANSITION_LINK,
       false);
+
+  if (download->GetTargetFilePath().MatchesExtension(
+          FILE_PATH_LITERAL(".crt"))) {
+    params = content::OpenURLParams(GURL("chrome://settings/certificates"),
+                                    content::Referrer(), NEW_FOREGROUND_TAB,
+                                    ui::PAGE_TRANSITION_LINK, false);

[Ryan Sleevi, 2015/10/30 23:33:45]

I don't think this is right - this would imply it opens for all OSes, right?

[svaldez, 2015/11/02 16:27:37]

This would only apply to OS_LINUX and OS_CHROMEOS due to the
IsOpenInBrowserPreferredForFile check below.

+  }
+
   browser->OpenURL(params);
   RecordDownloadOpenMethod(DOWNLOAD_OPEN_METHOD_DEFAULT_BROWSER);
 #else
   // ShouldPreferOpeningInBrowser() should never be true on Android.
   NOTREACHED();
 #endif
 }
 
 void ChromeDownloadManagerDelegate::ShowDownloadInShell(
     DownloadItem* download) {
@@ skipping 245 matching lines @@
       DownloadItemModel(item).SetIsDangerousFileBasedOnType(true);
   }
   callback.Run(target_info->target_path,
                target_info->target_disposition,
                target_info->danger_type,
                target_info->intermediate_path);
 }
 
 bool ChromeDownloadManagerDelegate::IsOpenInBrowserPreferreredForFile(
     const base::FilePath& path) {
+#if defined(OS_LINUX) || defined(OS_CHROMEOS)
+  if (path.MatchesExtension(FILE_PATH_LITERAL(".crt"))) {

[Ryan Sleevi, 2015/10/30 23:33:46]

This doesn't handle the general mimetype, right?

(This type is possible to have extensions .pem, .crt, .cert, .p7b, .pfx, and
several others; I don't know what the "right" answer is here)

[svaldez, 2015/11/02 16:27:37]

This is explicitly for dealing with downloaded files that result from
x-x509-user-cert, which will be '.crt' files. For other .pem, .cert, .p7b, .pfx
files, we would be handling them as before, where they are just a downloaded
file handled by the default system handlers.

+    return true;
+  }
+#endif
+
 #if defined(OS_WIN) || defined(OS_LINUX) || \
     (defined(OS_MACOSX) && !defined(OS_IOS))
   if (path.MatchesExtension(FILE_PATH_LITERAL(".pdf"))) {
     return !download_prefs_->ShouldOpenPdfInSystemReader();
   }
 #endif
 
   // On Android, always prefer opening with an external app. On ChromeOS, there
   // are no external apps so just allow all opens to be handled by the "System."
 #if !defined(OS_ANDROID) && !defined(OS_CHROMEOS) && defined(ENABLE_PLUGINS)
   // TODO(asanka): Consider other file types and MIME types.
   // http://crbug.com/323561
   if (path.MatchesExtension(FILE_PATH_LITERAL(".pdf")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".htm")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".html")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".shtm")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".shtml")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".svg")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".xht")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".xhtm")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".xhtml")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".xsl")) ||
       path.MatchesExtension(FILE_PATH_LITERAL(".xslt"))) {
     return true;
   }
 #endif
   return false;
 }