base/containers/scoped_ptr_hash_map.h - Issue 1423663010: Change ScopedPtr(Hash)Map to make qualified calls to ignore_result().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/containers/scoped_ptr_hash_map.h

Issue 1423663010: Change ScopedPtr(Hash)Map to make qualified calls to ignore_result(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/containers/scoped_ptr_hash_map.h

diff --git a/base/containers/scoped_ptr_hash_map.h b/base/containers/scoped_ptr_hash_map.h

index 8fe550e7317f7e79201c7ef801f01bc39cfd69ab..116070a095c0f64dff9b7b791533336dff992f48 100644

--- a/base/containers/scoped_ptr_hash_map.h

+++ b/base/containers/scoped_ptr_hash_map.h

@@ -57,7 +57,7 @@ class ScopedPtrHashMap {

std::pair<iterator, bool> result =

data_.insert(std::make_pair(key, data.get()));

if (result.second)

- ignore_result(data.release());

+ ::ignore_result(data.release());

return result;

}

« no previous file with comments | « no previous file | base/containers/scoped_ptr_hash_map_unittest.cc » ('j') | base/containers/scoped_ptr_hash_map_unittest.cc » ('J')