Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: ui/compositor/compositing_recorder.h

Issue 1423653005: Further plumb visual rect into cc:DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix cc unit tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/compositing_recorder.h
diff --git a/ui/compositor/compositing_recorder.h b/ui/compositor/compositing_recorder.h
index 729ddb9d5816f62a0972158e683eade9a42f2c86..19eb9389d60771ccfae3ff6074938c8239405074 100644
--- a/ui/compositor/compositing_recorder.h
+++ b/ui/compositor/compositing_recorder.h
@@ -8,6 +8,8 @@
#include "base/basictypes.h"
#include "base/macros.h"
#include "ui/compositor/compositor_export.h"
+#include "ui/gfx/geometry/rect.h"
+#include "ui/gfx/geometry/size.h"
danakj 2015/11/06 00:32:45 nit: forward declare size
namespace ui {
class PaintContext;
@@ -20,12 +22,15 @@ class PaintContext;
class COMPOSITOR_EXPORT CompositingRecorder {
public:
// |alpha| is a value between 0 and 255, where 0 is transparent and 255 is
- // opaque.
- CompositingRecorder(const PaintContext& context, uint8_t alpha);
+ // opaque. |visual_size| is the size of the bounding rect for painting.
danakj 2015/11/06 00:32:45 mention coordinate space of the layer? same q abou
wkorman 2015/11/16 19:01:03 Renamed to layer_size.
+ CompositingRecorder(const PaintContext& context,
+ const gfx::Size& visual_size,
+ uint8_t alpha);
~CompositingRecorder();
private:
const PaintContext& context_;
+ const gfx::Rect visual_rect_;
danakj 2015/11/06 00:32:45 How about storing the size, and convert to a rect
wkorman 2015/11/16 19:01:03 Discussed in person, let's try it this way, can tr
bool saved_;
DISALLOW_COPY_AND_ASSIGN(CompositingRecorder);

Powered by Google App Engine
This is Rietveld 408576698