Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: ui/views/view.cc

Issue 1423653005: Further plumb visual rect into cc:DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment per danakj. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/compositor/clip_transform_recorder.h ('K') | « ui/compositor/paint_recorder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view.cc
diff --git a/ui/views/view.cc b/ui/views/view.cc
index 0fc755972d6d57de055a7ea9d31fa11733eaf13b..7093d056850bd1c0a0f3e69c0c450192734334e5 100644
--- a/ui/views/view.cc
+++ b/ui/views/view.cc
@@ -777,7 +777,7 @@ void View::Paint(const ui::PaintContext& parent_context) {
// If the view is backed by a layer, it should paint with itself as the origin
// rather than relative to its parent.
- ui::ClipTransformRecorder clip_transform_recorder(context);
+ ui::ClipTransformRecorder clip_transform_recorder(context, size());
if (!layer()) {
// Set the clip rect to the bounds of this View. Note that the X (or left)
// position we pass to ClipRect takes into consideration whether or not the
@@ -800,7 +800,10 @@ void View::Paint(const ui::PaintContext& parent_context) {
clip_transform_recorder.Transform(transform_from_parent);
}
- if (is_invalidated || !paint_cache_.UseCache(context)) {
+ // Note that the cache is not aware of the offset of the view
+ // relative to the parent since painting is always done relative to
+ // the top left of the individual view.
+ if (is_invalidated || !paint_cache_.UseCache(context, size())) {
ui::PaintRecorder recorder(context, size(), &paint_cache_);
gfx::Canvas* canvas = recorder.canvas();
« ui/compositor/clip_transform_recorder.h ('K') | « ui/compositor/paint_recorder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698