cc/trees/layer_tree_host_pixeltest_masks.cc - Issue 1423653005: Further plumb visual rect into cc:DisplayItemList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_pixeltest_masks.cc

Issue 1423653005: Further plumb visual rect into cc:DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment per danakj. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_pixeltest_masks.cc

diff --git a/cc/trees/layer_tree_host_pixeltest_masks.cc b/cc/trees/layer_tree_host_pixeltest_masks.cc

index 6d3313c746710f2d2e6d3b4894d444c7d9d7c179..af57764836f1c216f7d991b2bc4fb95474a09cad 100644

--- a/cc/trees/layer_tree_host_pixeltest_masks.cc

+++ b/cc/trees/layer_tree_host_pixeltest_masks.cc

@@ -57,7 +57,7 @@ class MaskContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(clip, DisplayItemListSettings());

- auto* item = display_list->CreateAndAppendItem<DrawingDisplayItem>();

+ auto* item = display_list->CreateAndAppendItem<DrawingDisplayItem>(clip);

skia::RefPtr<SkPicture> picture =

skia::AdoptRef(recorder.endRecordingAsPicture());

@@ -335,7 +335,7 @@ class CheckerContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(clip, DisplayItemListSettings());

- auto* item = display_list->CreateAndAppendItem<DrawingDisplayItem>();

+ auto* item = display_list->CreateAndAppendItem<DrawingDisplayItem>(clip);

skia::RefPtr<SkPicture> picture =

skia::AdoptRef(recorder.endRecordingAsPicture());

@@ -376,7 +376,7 @@ class CircleContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(clip, DisplayItemListSettings());

- auto* item = display_list->CreateAndAppendItem<DrawingDisplayItem>();

+ auto* item = display_list->CreateAndAppendItem<DrawingDisplayItem>(clip);

skia::RefPtr<SkPicture> picture =

skia::AdoptRef(recorder.endRecordingAsPicture());

item->SetNew(std::move(picture));