Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: cc/playback/display_item_proto_factory.cc

Issue 1423653005: Further plumb visual rect into cc:DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address more danakj@ feedback. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/playback/display_item_proto_factory.h" 5 #include "cc/playback/display_item_proto_factory.h"
6 6
7 #include "cc/playback/clip_display_item.h" 7 #include "cc/playback/clip_display_item.h"
8 #include "cc/playback/clip_path_display_item.h" 8 #include "cc/playback/clip_path_display_item.h"
9 #include "cc/playback/compositing_display_item.h" 9 #include "cc/playback/compositing_display_item.h"
10 #include "cc/playback/drawing_display_item.h" 10 #include "cc/playback/drawing_display_item.h"
11 #include "cc/playback/filter_display_item.h" 11 #include "cc/playback/filter_display_item.h"
12 #include "cc/playback/float_clip_display_item.h" 12 #include "cc/playback/float_clip_display_item.h"
13 #include "cc/playback/transform_display_item.h" 13 #include "cc/playback/transform_display_item.h"
14 #include "cc/proto/display_item.pb.h" 14 #include "cc/proto/display_item.pb.h"
15 #include "ui/gfx/geometry/rect.h"
15 16
16 namespace cc { 17 namespace cc {
17 18
18 // static 19 // static
19 DisplayItem* DisplayItemProtoFactory::AllocateAndConstruct( 20 DisplayItem* DisplayItemProtoFactory::AllocateAndConstruct(
21 const gfx::Rect& visual_rect,
20 scoped_refptr<DisplayItemList> list, 22 scoped_refptr<DisplayItemList> list,
21 const proto::DisplayItem& proto) { 23 const proto::DisplayItem& proto) {
22 switch (proto.type()) { 24 switch (proto.type()) {
23 case proto::DisplayItem::Type_Clip: 25 case proto::DisplayItem::Type_Clip:
24 return list->CreateAndAppendItem<ClipDisplayItem>(); 26 return list->CreateAndAppendItem<ClipDisplayItem>(visual_rect);
25 case proto::DisplayItem::Type_EndClip: 27 case proto::DisplayItem::Type_EndClip:
26 return list->CreateAndAppendItem<EndClipDisplayItem>(); 28 return list->CreateAndAppendItem<EndClipDisplayItem>(visual_rect);
27 case proto::DisplayItem::Type_ClipPath: 29 case proto::DisplayItem::Type_ClipPath:
28 return list->CreateAndAppendItem<ClipPathDisplayItem>(); 30 return list->CreateAndAppendItem<ClipPathDisplayItem>(visual_rect);
29 case proto::DisplayItem::Type_EndClipPath: 31 case proto::DisplayItem::Type_EndClipPath:
30 return list->CreateAndAppendItem<EndClipPathDisplayItem>(); 32 return list->CreateAndAppendItem<EndClipPathDisplayItem>(visual_rect);
31 case proto::DisplayItem::Type_Compositing: 33 case proto::DisplayItem::Type_Compositing:
32 return list->CreateAndAppendItem<CompositingDisplayItem>(); 34 return list->CreateAndAppendItem<CompositingDisplayItem>(visual_rect);
33 case proto::DisplayItem::Type_EndCompositing: 35 case proto::DisplayItem::Type_EndCompositing:
34 return list->CreateAndAppendItem<EndCompositingDisplayItem>(); 36 return list->CreateAndAppendItem<EndCompositingDisplayItem>(visual_rect);
35 case proto::DisplayItem::Type_Drawing: 37 case proto::DisplayItem::Type_Drawing:
36 return list->CreateAndAppendItem<DrawingDisplayItem>(); 38 return list->CreateAndAppendItem<DrawingDisplayItem>(visual_rect);
37 case proto::DisplayItem::Type_Filter: 39 case proto::DisplayItem::Type_Filter:
38 return list->CreateAndAppendItem<FilterDisplayItem>(); 40 return list->CreateAndAppendItem<FilterDisplayItem>(visual_rect);
39 case proto::DisplayItem::Type_EndFilter: 41 case proto::DisplayItem::Type_EndFilter:
40 return list->CreateAndAppendItem<EndFilterDisplayItem>(); 42 return list->CreateAndAppendItem<EndFilterDisplayItem>(visual_rect);
41 case proto::DisplayItem::Type_FloatClip: 43 case proto::DisplayItem::Type_FloatClip:
42 return list->CreateAndAppendItem<FloatClipDisplayItem>(); 44 return list->CreateAndAppendItem<FloatClipDisplayItem>(visual_rect);
43 case proto::DisplayItem::Type_EndFloatClip: 45 case proto::DisplayItem::Type_EndFloatClip:
44 return list->CreateAndAppendItem<EndFloatClipDisplayItem>(); 46 return list->CreateAndAppendItem<EndFloatClipDisplayItem>(visual_rect);
45 case proto::DisplayItem::Type_Transform: 47 case proto::DisplayItem::Type_Transform:
46 return list->CreateAndAppendItem<TransformDisplayItem>(); 48 return list->CreateAndAppendItem<TransformDisplayItem>(visual_rect);
47 case proto::DisplayItem::Type_EndTransform: 49 case proto::DisplayItem::Type_EndTransform:
48 return list->CreateAndAppendItem<EndTransformDisplayItem>(); 50 return list->CreateAndAppendItem<EndTransformDisplayItem>(visual_rect);
49 } 51 }
50 52
51 NOTREACHED(); 53 NOTREACHED();
52 return nullptr; 54 return nullptr;
53 } 55 }
54 56
55 } // namespace cc 57 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698