Further plumb visual rect into cc:DisplayItemList.

cc/playback/display_item_list.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_PLAYBACK_DISPLAY_ITEM_LIST_H_
 #define CC_PLAYBACK_DISPLAY_ITEM_LIST_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 43 matching lines @@
               SkPicture::AbortCallback* callback,
               const gfx::Rect& canvas_target_playback_rect,
               float contents_scale) const;
 
   // This is a fast path for use only if canvas_ is set and
   // retain_individual_display_items_ is false. This method also updates
   // is_suitable_for_gpu_rasterization_ and approximate_op_count_.
   void RasterIntoCanvas(const DisplayItem& display_item);
 
   template <typename DisplayItemType>
-  DisplayItemType* CreateAndAppendItem() {
+  DisplayItemType* CreateAndAppendItem(const gfx::Rect& visual_rect) {
 #if DCHECK_IS_ON()
     needs_process_ = true;
 #endif
+    visual_rects_.push_back(visual_rect);
     ProcessAppendedItemsOnTheFly();
     return items_.AllocateAndConstruct<DisplayItemType>();
   }
 
   // Removes the last item. This cannot be called on lists with cached pictures
   // (since the data may already have been incorporated into cached picture
   // sizes, etc).
   void RemoveLast();
 
   // Called after all items are appended, to process the items and, if
@@ skipping 28 matching lines @@
   void ProcessAppendedItemsOnTheFly();
   void ProcessAppendedItems();
 #if DCHECK_IS_ON()
   bool ProcessAppendedItemsCalled() const { return !needs_process_; }
   bool needs_process_;
 #else
   bool ProcessAppendedItemsCalled() const { return true; }
 #endif
 
   ListContainer<DisplayItem> items_;
+  // The visual rects associated with each of the display items in the
+  // display item list. There is one rect per display item, and the
+  // position in the vector matches the position of the item in the

[danakj, 2015/11/05 23:54:27]

nit: the position in |visual_rects_| matches the position of the item in
|items_|

[wkorman, 2015/11/17 01:47:23]

Done.

+  // display item list. These rects are intentionally kept separate
+  // from the items so as to keep the display items small.

[danakj, 2015/11/05 23:54:27]

because they are not needed while walking the |items_| for raster.

[wkorman, 2015/11/17 01:47:23]

Done.

+  std::vector<gfx::Rect> visual_rects_;
   skia::RefPtr<SkPicture> picture_;
 
   scoped_ptr<SkPictureRecorder> recorder_;
   skia::RefPtr<SkCanvas> canvas_;
   const DisplayItemListSettings settings_;
   bool retain_individual_display_items_;
 
   gfx::Rect layer_rect_;
   bool is_suitable_for_gpu_rasterization_;
   int approximate_op_count_;
 
   // Memory usage due to the cached SkPicture.
   size_t picture_memory_usage_;
 
   // Memory usage due to external data held by display items.
   size_t external_memory_usage_;
 
   DiscardableImageMap image_map_;
 
   friend class base::RefCountedThreadSafe<DisplayItemList>;
   FRIEND_TEST_ALL_PREFIXES(DisplayItemListTest, ApproximateMemoryUsage);
   DISALLOW_COPY_AND_ASSIGN(DisplayItemList);
 };
 
 }  // namespace cc
 
 #endif  // CC_PLAYBACK_DISPLAY_ITEM_LIST_H_