Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1423643002: Print absolutely positioned objects correctly when sized against the viewport. (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print absolutely positioned objects correctly when sized against the viewport. Remove special code for printing from computeLogicalHeight() and updateLogicalWidth() in LayoutView. The size of the containing block established by the viewport should be equal to the size of the page, not the size of the document. Return the correct page size from LayoutView::layoutSize() instead of 0x0. Special code is still needed here, because we cannot use FrameView to get the page size (because the size of the FrameView corresponds to what we have on the screen). BUG=544794 R=leviw@chromium.org Committed: https://crrev.com/fe1888ab535da3df53c670f5e6a68bd9a87158ce Cr-Commit-Position: refs/heads/master@{#355760}

Patch Set 1 #

Patch Set 2 : rebase master #

Patch Set 3 : Need to rebaseline some tests, and it has to be done manually because of more specific entries alre… #

Messages

Total messages: 11 (4 generated)
mstensho (USE GERRIT)
5 years, 2 months ago (2015-10-22 14:58:29 UTC) #1
leviw_travelin_and_unemployed
lgtm
5 years, 2 months ago (2015-10-22 17:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423643002/1
5 years, 2 months ago (2015-10-22 17:30:40 UTC) #4
mstensho (USE GERRIT)
I think this CL is going to affect some layout tree dump expectations for tests ...
5 years, 2 months ago (2015-10-22 19:30:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423643002/40001
5 years, 2 months ago (2015-10-23 08:02:30 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-23 09:54:59 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 09:55:37 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe1888ab535da3df53c670f5e6a68bd9a87158ce
Cr-Commit-Position: refs/heads/master@{#355760}

Powered by Google App Engine
This is Rietveld 408576698