Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: tests/compiler/dart2js/diagnose_ambiguous_test.dart

Issue 1423623008: Improve messages and static use for super/this-calls. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/typechecker.dart ('k') | tests/compiler/dart2js/memory_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/diagnose_ambiguous_test.dart
diff --git a/tests/compiler/dart2js/diagnose_ambiguous_test.dart b/tests/compiler/dart2js/diagnose_ambiguous_test.dart
index 09e87060bd8d741e58ea9dc76ecb87fa01a83a52..2ae75ca2ca5eb9a68859c3b66ca7617d7c0fd303 100644
--- a/tests/compiler/dart2js/diagnose_ambiguous_test.dart
+++ b/tests/compiler/dart2js/diagnose_ambiguous_test.dart
@@ -23,11 +23,16 @@ void main() {
});
diagnostics.sort();
var expected = [
- "memory:exporter.dart:43:47:'hest' is defined here.:info",
- "memory:library.dart:41:45:'hest' is defined here.:info",
- "memory:main.dart:0:22:'hest' is imported here.:info",
- "memory:main.dart:23:46:'hest' is imported here.:info",
- "memory:main.dart:86:92:Duplicate import of 'hest'.:warning",
+ "MessageKind.AMBIGUOUS_LOCATION:"
+ "memory:exporter.dart:43:47:'hest' is defined here.:info",
+ "MessageKind.AMBIGUOUS_LOCATION:"
+ "memory:library.dart:41:45:'hest' is defined here.:info",
+ "MessageKind.DUPLICATE_IMPORT:"
+ "memory:main.dart:86:92:Duplicate import of 'hest'.:warning",
+ "MessageKind.IMPORTED_HERE:"
+ "memory:main.dart:0:22:'hest' is imported here.:info",
+ "MessageKind.IMPORTED_HERE:"
+ "memory:main.dart:23:46:'hest' is imported here.:info",
];
Expect.listEquals(expected, diagnostics);
Expect.isTrue(result.isSuccess);
« no previous file with comments | « pkg/compiler/lib/src/typechecker.dart ('k') | tests/compiler/dart2js/memory_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698