Issue 1423623005: Report hint when target of an invocation uses '?.', so can be null.

Issue 1423623005: Report hint when target of an invocation uses '?.', so can be null. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Report hint when target of an invocation uses '?.', so can be null. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2529e684f0f5080958941a3baf6414a27a7869a7

Patch Set 1 #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -0 lines)			Patch
M	pkg/analyzer/lib/src/generated/error.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	3 chunks	+31 lines, -0 lines	2 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1423623005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1423623005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode479 pkg/analyzer/lib/src/generated/resolver.dart:479: if (expression.operator?.type == TokenType.QUESTION_PERIOD) { I don't think ...

5 years, 1 month ago (2015-10-28 22:09:11 UTC) #2

scheglov

https://codereview.chromium.org/1423623005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1423623005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode479 pkg/analyzer/lib/src/generated/resolver.dart:479: if (expression.operator?.type == TokenType.QUESTION_PERIOD) { On 2015/10/28 22:09:11, Brian ...

5 years, 1 month ago (2015-10-28 23:45:09 UTC) #3

scheglov

5 years, 1 month ago (2015-10-28 23:45:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2529e684f0f5080958941a3baf6414a27a7869a7 (presubmit successful).

Expand Messages | Collapse Messages