Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1423603002: Fix corner-case behavior of JSObject::SetPrototype. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix corner-case behavior of JSObject::SetPrototype. Setting the prototype to whatever it currently is must succeed even if the object is not extensible. R=verwaest@chromium.org BUG= Committed: https://crrev.com/193410062ec8a0722dd261f9d14bf1ec29d54f7b Cr-Commit-Position: refs/heads/master@{#31527}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M src/objects.cc View 3 chunks +24 lines, -29 lines 3 comments Download
M test/mjsunit/harmony/reflect-set-prototype-of.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/set-prototype-of.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
neis
5 years, 2 months ago (2015-10-22 11:41:35 UTC) #1
Toon Verwaest
lgtm with nit https://codereview.chromium.org/1423603002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1423603002/diff/1/src/objects.cc#newcode13952 src/objects.cc:13952: real_receiver = PrototypeIterator::GetCurrent<JSObject>(iter); This code is ...
5 years, 2 months ago (2015-10-22 13:21:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423603002/1
5 years, 2 months ago (2015-10-23 14:26:47 UTC) #4
neis
https://codereview.chromium.org/1423603002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1423603002/diff/1/src/objects.cc#newcode13957 src/objects.cc:13957: Handle<Map> map(real_receiver->map()); On 2015/10/22 13:21:07, Toon Verwaest wrote: > ...
5 years, 2 months ago (2015-10-23 14:26:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 14:52:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 14:52:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/193410062ec8a0722dd261f9d14bf1ec29d54f7b
Cr-Commit-Position: refs/heads/master@{#31527}

Powered by Google App Engine
This is Rietveld 408576698