Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1423583004: Revert of e2e928bacd07fead99a18cb08d64cb24e131d3e5 (Closed)

Created:
5 years, 1 month ago by scottmg
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai, aharper
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Revert of e2e928bacd07fead99a18cb08d64cb24e131d3e5 Causing failure in Chrome per https://codereview.chromium.org/1416453003/#msg8 (SetXcodeVersion doesn't exist.) TBR=aharper@chromium.org,mark@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/2c1e6cced23554ce84806e570acea637f6473afc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M pylib/gyp/generator/xcode.py View 2 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
scottmg
5 years, 1 month ago (2015-11-03 23:48:06 UTC) #2
scottmg
5 years, 1 month ago (2015-11-03 23:48:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c1e6cced23554ce84806e570acea637f6473afc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698