Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2326)

Unified Diff: base/BUILD.gn

Issue 1423583002: Stack sampling profiler: handle unloaded and unloading modules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: fix gcc compile Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 6639d6de5a03b07b536a6aa16eaf5c0ab2fa7937..38b47d81df5471c23b84b14719c5dabc9e072d18 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1190,6 +1190,18 @@ if (is_win) {
"//build/config/sanitizers:deps",
]
}
+
+ if (target_cpu == "x64") {
+ # Must be a shared library so that it can be unloaded during testing.
+ shared_library("base_profiler_test_support_library") {
+ sources = [
+ "profiler/test_support_library.cc",
+ ]
+ deps = [
+ "//build/config/sanitizers:deps",
+ ]
+ }
+ }
}
# TODO(GYP): Delete this after we've converted everything to GN.
@@ -1529,8 +1541,9 @@ test("base_unittests") {
set_sources_assignment_filter(sources_assignment_filter)
}
- if (is_win) {
+ if (is_win && target_cpu == "x64") {
sources += [ "profiler/win32_stack_frame_unwinder_unittest.cc" ]
+ deps += [ ":base_profiler_test_support_library" ]
}
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698