Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1423563008: Fixing asm typing issues. (Closed)

Created:
5 years, 1 month ago by bradn
Modified:
5 years, 1 month ago
Reviewers:
titzer, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixing asm typing issues. Fixing handling of uint32 to be more correct (previously some uint32's were being interpreted as int32). Fixing enforcement type matching in comparisons (previously mismatched expressions could be compared). BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/b0f7830bef9803b7b49693d1db7cd3521dfd0fbb Cr-Commit-Position: refs/heads/master@{#31726}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : revised #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -27 lines) Patch
M src/typing-asm.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/typing-asm.cc View 1 2 3 chunks +38 lines, -27 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 3 chunks +145 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bradn
5 years, 1 month ago (2015-11-02 22:51:02 UTC) #1
titzer
logic lgtm modulo refactoro https://codereview.chromium.org/1423563008/diff/20001/src/typing-asm.cc File src/typing-asm.cc (right): https://codereview.chromium.org/1423563008/diff/20001/src/typing-asm.cc#newcode819 src/typing-asm.cc:819: Type* expectation; Is it time ...
5 years, 1 month ago (2015-11-02 22:57:15 UTC) #2
bradn
https://codereview.chromium.org/1423563008/diff/20001/src/typing-asm.cc File src/typing-asm.cc (right): https://codereview.chromium.org/1423563008/diff/20001/src/typing-asm.cc#newcode819 src/typing-asm.cc:819: Type* expectation; On 2015/11/02 22:57:15, titzer wrote: > Is ...
5 years, 1 month ago (2015-11-03 00:10:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423563008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423563008/40001
5 years, 1 month ago (2015-11-03 00:10:38 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-03 00:29:20 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 00:29:38 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0f7830bef9803b7b49693d1db7cd3521dfd0fbb
Cr-Commit-Position: refs/heads/master@{#31726}

Powered by Google App Engine
This is Rietveld 408576698