Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1423523005: Merge to XFA: Allow running individual tests. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Allow running individual tests. This CL adds the ability to run a given test from the corpus, javascript and pixel test runners. The filename to provide is relative to the testing directory in question. Because the directories for javascript and pixel are flat you just provide the filename (it will rewrite the .pdf to .in if .pdf is provided). For corpus tests you have to provide the path from the corpus directory. Development/pdfium/pdfium % ./testing/tools/run_javascript_tests.py apply.pdf Rendering PDF file /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/javascript/apply.pdf. Non-linearized path... Rendered 1 pages. Skipped 0 bad pages. Development/pdfium/pdfium % ./testing/tools/run_pixel_tests.py bug_524043_1.pdf Rendering PDF file /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/pixel/bug_524043_1.pdf. Linearized path... Rendered 1 pages. Skipped 0 bad pages. Checking /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/pixel/bug_524043_1.pdf.0.png diff: 0.00% passed Development/pdfium/pdfium % ./testing/tools/run_corpus_tests.py third_party/tcpdf/example_065.pdf Rendering PDF file /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/corpus/example_065.pdf. Non-linearized path... Rendered 1 pages. Skipped 0 bad pages. Checking /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/corpus/example_065.pdf.0.png diff: 0.14% failed FAILURE: example_065.pdf; Command '['/Development/pdfium/pdfium/out/Debug/pdfium_diff', '/Development/pdfium/pdfium/testing/corpus/third_party/tcpdf/example_065_expected.pdf.0.png', '/Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/corpus/example_065.pdf.0.png']' returned non-zero exit status 1 Summary of Failures: /Development/pdfium/pdfium/testing/corpus/third_party/tcpdf/example_065.pdf TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1407913005 . (cherry picked from commit da6254ff78553773b7bb637ee1e3f5111c083c74) Committed: https://pdfium.googlesource.com/pdfium/+/456b923e60071b10c5cd9a2a907f7c190d548942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M testing/tools/run_corpus_tests.py View 1 chunk +18 lines, -7 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 2 chunks +9 lines, -1 line 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
TBRing, merge clean.
5 years, 1 month ago (2015-10-28 21:12:27 UTC) #1
dsinclair
Committed patchset #1 (id:1) manually as 456b923e60071b10c5cd9a2a907f7c190d548942 (presubmit successful).
5 years, 1 month ago (2015-10-28 21:12:36 UTC) #2
Lei Zhang
5 years, 1 month ago (2015-10-28 21:19:27 UTC) #3
Message was sent while issue was closed.
lgtm stamp

Powered by Google App Engine
This is Rietveld 408576698