Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 14235017: Implement ComposedCallback with three arguments and the second one is scoped_ptr. (Closed)

Created:
7 years, 8 months ago by hidehiko
Modified:
7 years, 8 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Implement ComposedCallback with three arguments and the second one is scoped_ptr. Just add new pattern. It will be used to implement DriveFileStreamReader. BUG=127129 TEST=Ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/google_apis/task_util.h View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 8 months ago (2013-04-17 09:21:50 UTC) #1
hashimoto
lgtm
7 years, 8 months ago (2013-04-17 09:33:39 UTC) #2
hidehiko
7 years, 8 months ago (2013-04-17 11:13:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r194569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698