Issue 14235015: Fill JobInfo in DriveScheduler.

Issue 14235015: Fill JobInfo in DriveScheduler. (Closed)

Created:
7 years, 8 months ago by kinaba

Modified:
7 years, 8 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Zachary Kuznia

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fill JobInfo in DriveScheduler. BUG=128079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194786

Patch Set 2 : Add comment for |file_path|'s availability. #

Patch Set 3 : Reorder initializers. #

Patch Set 4 : Rebase #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -23 lines)			Patch
M	chrome/browser/chromeos/drive/drive_scheduler.h	View	1 2	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler.cc	View		6 chunks	+22 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler_unittest.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/job_list_interface.h	View	1 2	2 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kinaba

PTAL. I'd like to add tests in separate patch once https://codereview.chromium.org/14235015/ landed and I added ...

7 years, 8 months ago (2013-04-17 06:08:16 UTC) #1

hidehiko

FYI: the code looks good, but please let me ask a question. https://codereview.chromium.org/14235015/diff/1/chrome/browser/chromeos/drive/drive_scheduler.cc File chrome/browser/chromeos/drive/drive_scheduler.cc ...

7 years, 8 months ago (2013-04-17 06:23:21 UTC) #3

kinaba

https://codereview.chromium.org/14235015/diff/1/chrome/browser/chromeos/drive/drive_scheduler.cc File chrome/browser/chromeos/drive/drive_scheduler.cc (right): https://codereview.chromium.org/14235015/diff/1/chrome/browser/chromeos/drive/drive_scheduler.cc#newcode366 chrome/browser/chromeos/drive/drive_scheduler.cc:366: job_info->file_path = job->drive_file_path; On 2013/04/17 06:23:21, hidehiko wrote: > ...

7 years, 8 months ago (2013-04-17 06:41:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14235015/12001

7 years, 8 months ago (2013-04-18 00:24:21 UTC) #6

Message was sent while issue was closed.

Change committed as 194786

Expand Messages | Collapse Messages