ios/web/crw_browsing_data_store.mm - Issue 1423483004: Updated TODO(shreyasv)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/crw_browsing_data_store.mm

Issue 1423483004: Updated TODO(shreyasv) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/web/browsing_data_managers/crw_cookie_browsing_data_manager.mm ('k') | ios/web/public/test/crw_test_js_injection_receiver.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/crw_browsing_data_store.mm

diff --git a/ios/web/crw_browsing_data_store.mm b/ios/web/crw_browsing_data_store.mm

index c0826ce47674b62fcdbc2b2497b990949a729fcb..fe93382762318d3c8dab52f459d24553d7a34e1d 100644

--- a/ios/web/crw_browsing_data_store.mm

+++ b/ios/web/crw_browsing_data_store.mm

@@ -150,15 +150,11 @@ NSString* const kStashOperationName = @"CRWBrowsingDataStore.STASH";

if (self) {

DCHECK([NSThread isMainThread]);

DCHECK(browserState);

- // TODO(shreyasv): Instantiate the necessary CRWBrowsingDataManagers that

- // are encapsulated within this class. crbug.com/480654.

_browserState = browserState;

web::ActiveStateManager* activeStateManager =

web::BrowserState::GetActiveStateManager(browserState);

DCHECK(activeStateManager);

_mode = activeStateManager->IsActive() ? web::ACTIVE : web::INACTIVE;

- // TODO(shreyasv): If the creation of CRWBrowsingDataManagers turns out to

- // be an expensive operations re-visit this with a lazy-evaluation approach.

base::scoped_nsobject<CRWCookieBrowsingDataManager>

cookieBrowsingDataManager([[CRWCookieBrowsingDataManager alloc]

initWithBrowserState:browserState]);

@@ -237,8 +233,6 @@ NSString* const kStashOperationName = @"CRWBrowsingDataStore.STASH";

- (void)makeActiveWithCompletionHandler:

(void (^)(BOOL success))completionHandler {

DCHECK([NSThread isMainThread]);

- // TODO(shreyasv): Verify the preconditions for this method when

- // web::WebViewCounter class is implemented. crbug.com/480507.

[self changeMode:web::ACTIVE completionHandler:completionHandler];

}

@@ -246,8 +240,6 @@ NSString* const kStashOperationName = @"CRWBrowsingDataStore.STASH";

- (void)makeInactiveWithCompletionHandler:

(void (^)(BOOL success))completionHandler {

DCHECK([NSThread isMainThread]);

- // TODO(shreyasv): Verify the preconditions for this method when

- // web::WebViewCounter class is implemented. crbug.com/480507.

[self changeMode:web::INACTIVE completionHandler:completionHandler];

}

@@ -255,8 +247,6 @@ NSString* const kStashOperationName = @"CRWBrowsingDataStore.STASH";

- (void)removeDataOfTypes:(web::BrowsingDataTypes)browsingDataTypes

completionHandler:(ProceduralBlock)completionHandler {

DCHECK([NSThread isMainThread]);

- // TODO(shreyasv): Verify the preconditions for this method when

- // web::WebViewCounter class is implemented. crbug.com/480507.

NSArray* browsingDataManagers =

[self browsingDataManagersForBrowsingDataTypes:browsingDataTypes];