ios/chrome/browser/snapshots/snapshot_manager.h - Issue 1423483004: Updated TODO(shreyasv)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/snapshots/snapshot_manager.h

Issue 1423483004: Updated TODO(shreyasv) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/snapshots/snapshot_manager.h

diff --git a/ios/chrome/browser/snapshots/snapshot_manager.h b/ios/chrome/browser/snapshots/snapshot_manager.h

index 82d3511a7cbf5b6450151ac6040c9fbe421b5de8..13e4fce5f2e51f6bf9e4d5fb82663c6c6cc731ee 100644

--- a/ios/chrome/browser/snapshots/snapshot_manager.h

+++ b/ios/chrome/browser/snapshots/snapshot_manager.h

@@ -28,8 +28,6 @@

withRect:(CGRect)rect

overlays:(NSArray*)overlays;

-// TODO(shreyasv): Consider passing the sessionID into SnapshotManager from Tab

Eugene But (OOO till 7-30) 2015/10/22 00:12:02 Why this TODO is not relevant anymore? Every metho

shreyasv1 2015/10/22 00:33:59 Done.

-// in the init method and simplifying the following methods.

// Retrieve a cached snapshot for the |sessionID| and return it via the callback

// if it exists. The callback is garanteed to be called synchronously if the

// image is in memory. It will be called asynchronously if the image is on disk