ios/web/web_state/ui/wk_web_view_configuration_provider.mm - Issue 1423483004: Updated TODO(shreyasv)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/web_state/ui/wk_web_view_configuration_provider.mm

Issue 1423483004: Updated TODO(shreyasv) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/web/public/test/crw_test_js_injection_receiver.mm ('K') | « ios/web/public/web_state/ui/crw_native_content.h ('k') | ios/web/web_state/web_state_impl.h » ('j') | ios/web/web_state/web_state_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "ios/web/web_state/ui/wk_web_view_configuration_provider.h"	5 #import "ios/web/web_state/ui/wk_web_view_configuration_provider.h"

6	6

7 #import <Foundation/Foundation.h>	7 #import <Foundation/Foundation.h>

8 #import <objc/runtime.h>	8 #import <objc/runtime.h>

9 #import <WebKit/WebKit.h>	9 #import <WebKit/WebKit.h>

10	10

(...skipping 169 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
180 #if !defined(NDEBUG) \|\| !defined(DCHECK_ALWAYS_ON) // Matches DCHECK_IS_ON.	180 #if !defined(NDEBUG) \|\| !defined(DCHECK_ALWAYS_ON) // Matches DCHECK_IS_ON.

181 base::WeakNSObject<id> weak_configuration(configuration_);	181 base::WeakNSObject<id> weak_configuration(configuration_);

182 base::WeakNSObject<id> weak_router(router_);	182 base::WeakNSObject<id> weak_router(router_);

183 base::WeakNSObject<id> weak_process_pool([configuration_ processPool]);	183 base::WeakNSObject<id> weak_process_pool([configuration_ processPool]);

184 #endif // !defined(NDEBUG) \|\| defined(DCHECK_ALWAYS_ON)	184 #endif // !defined(NDEBUG) \|\| defined(DCHECK_ALWAYS_ON)

185 configuration_.reset();	185 configuration_.reset();

186 router_.reset();	186 router_.reset();

187 // Make sure that no one retains configuration, router, processPool.	187 // Make sure that no one retains configuration, router, processPool.

188 DCHECK(!weak_configuration);	188 DCHECK(!weak_configuration);

189 DCHECK(!weak_router);	189 DCHECK(!weak_router);

190 // TODO(shreyasv): Enable this DCHECK (crbug.com/522672).	190 // TODO(crbug.com/522672): Enable this DCHECK.

191 // DCHECK(!weak_process_pool);	191 // DCHECK(!weak_process_pool);

192 }	192 }

193	193

194 } // namespace web	194 } // namespace web

OLD	NEW