Updated TODO(shreyasv)

ios/web/public/test/crw_test_js_injection_receiver.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/public/test/crw_test_js_injection_receiver.h"
 
 #import <UIKit/UIKit.h>
 
+#include "base/ios/weak_nsobject.h"
 #import "base/mac/scoped_nsobject.h"
 #import "ios/web/public/web_state/js/crw_js_injection_evaluator.h"
 
 @interface CRWTestUIWebViewEvaluator : NSObject<CRWJSInjectionEvaluator> {
   base::scoped_nsobject<UIWebView> _webView;
 }
 @end
 
 @implementation CRWTestUIWebViewEvaluator
 
 - (id) init {
   if (self = [super init])
     _webView.reset([[UIWebView alloc] init]);
   return self;
 }
 
 #pragma mark -
 #pragma mark CRWJSInjectionEvaluatorMethods
 
 - (void)evaluateJavaScript:(NSString*)script
        stringResultHandler:(web::JavaScriptCompletion)handler {
+  base::WeakNSObject<CRWTestUIWebViewEvaluator> weakEvaluator(self);

[Eugene But (OOO till 7-30), 2015/10/22 00:12:02]

NIT: s/weakEvaluator/weakSelf since we usually call this variable weakSelf

[shreyasv1, 2015/10/22 00:33:59]

Acknowledged.

   dispatch_async(dispatch_get_main_queue(), ^{
-      // TODO(shreyasv): Change to weaknsobject once weaknsobject is moved to
-      // ios/base.
+      UIWebView* webView = weakEvaluator ? weakEvaluator->_webView : nil;

[sdefresne, 2015/10/22 03:17:33]

Looks like you need the following to fix the compilation error:

UIWebView* webView = weakEvaluator ? weakEvaluator.get()->_webView : nil;

[shreyasv1, 2015/10/22 17:08:26]

Done.

       NSString* result =
-          [_webView stringByEvaluatingJavaScriptFromString:script];
+          [webView stringByEvaluatingJavaScriptFromString:script];
       if (handler)
         handler(result, nil);
   });
 }
 
 - (BOOL)scriptHasBeenInjectedForClass:(Class)jsInjectionManagerClass
                        presenceBeacon:(NSString*)beacon {
   NSString* result = [_webView stringByEvaluatingJavaScriptFromString:
       [NSString stringWithFormat:@"typeof %@", beacon]];
   return [result isEqualToString:@"object"];
@@ skipping 21 matching lines @@
 
 - (id)init {
   base::scoped_nsobject<CRWTestUIWebViewEvaluator> evaluator(
       [[CRWTestUIWebViewEvaluator alloc] init]);
   if (self = [super initWithEvaluator:evaluator])
     evaluator_.swap(evaluator);
   return self;
 }
 
 @end