Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: runtime/vm/thread_interrupter_macos.cc

Issue 1423473004: Switch profiler from isolates to threads [second landing] (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread_interrupter_linux.cc ('k') | runtime/vm/thread_interrupter_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_interrupter_macos.cc
diff --git a/runtime/vm/thread_interrupter_macos.cc b/runtime/vm/thread_interrupter_macos.cc
index f1ff45ee5fc0ae2336e79ca5e868e70345fa9f02..c53ae133d7cfa3871057a4bb549649c83a6be1fc 100644
--- a/runtime/vm/thread_interrupter_macos.cc
+++ b/runtime/vm/thread_interrupter_macos.cc
@@ -5,8 +5,11 @@
#include "platform/globals.h"
#if defined(TARGET_OS_MACOS)
+#include <errno.h> // NOLINT
+
#include "vm/flags.h"
#include "vm/os.h"
+#include "vm/profiler.h"
#include "vm/signal_handler.h"
#include "vm/thread_interrupter.h"
@@ -26,22 +29,16 @@ class ThreadInterrupterMacOS : public AllStatic {
if (thread == NULL) {
return;
}
- ThreadInterruptCallback callback = NULL;
- void* callback_data = NULL;
- if (!thread->IsThreadInterrupterEnabled(&callback, &callback_data)) {
- return;
- }
// Extract thread state.
ucontext_t* context = reinterpret_cast<ucontext_t*>(context_);
mcontext_t mcontext = context->uc_mcontext;
InterruptedThreadState its;
- its.tid = thread->id();
its.pc = SignalHandler::GetProgramCounter(mcontext);
its.fp = SignalHandler::GetFramePointer(mcontext);
its.csp = SignalHandler::GetCStackPointer(mcontext);
its.dsp = SignalHandler::GetDartStackPointer(mcontext);
its.lr = SignalHandler::GetLinkRegister(mcontext);
- callback(its, callback_data);
+ Profiler::SampleThread(thread, its);
}
};
@@ -51,7 +48,7 @@ void ThreadInterrupter::InterruptThread(Thread* thread) {
OS::Print("ThreadInterrupter interrupting %p\n", thread->id());
}
int result = pthread_kill(thread->id(), SIGPROF);
- ASSERT(result == 0);
+ ASSERT((result == 0) || (result == ESRCH));
}
« no previous file with comments | « runtime/vm/thread_interrupter_linux.cc ('k') | runtime/vm/thread_interrupter_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698