runtime/vm/profiler_test.cc - Issue 1423473004: Switch profiler from isolates to threads [second landing]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler_test.cc

Issue 1423473004: Switch profiler from isolates to threads [second landing] (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/profiler_test.cc

diff --git a/runtime/vm/profiler_test.cc b/runtime/vm/profiler_test.cc

index 12c21d1e95ad6cc928cced0b00a95443ddd5beff..ca1df17d8e0738e2f7c51d20398239afa05b5206 100644

--- a/runtime/vm/profiler_test.cc

+++ b/runtime/vm/profiler_test.cc

@@ -846,7 +846,7 @@ TEST_CASE(Profiler_ClassAllocation) {

// TODO(johnmccutchan): Hookup native symbol resolver on Windows.

EXPECT_SUBSTRING("[Native]", walker.CurrentName());

#else

- EXPECT_SUBSTRING("dart::Profiler::RecordAllocation", walker.CurrentName());

+ EXPECT_SUBSTRING("dart::Profiler::SampleAllocation", walker.CurrentName());

#endif

EXPECT(!walker.Down());

}

« no previous file with comments | « runtime/vm/profiler_service.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »