Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1423463003: Rename QuicDataStream to QuicSpdyStream. No behavior change. (Closed)

Created:
5 years, 2 months ago by alyssar1
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@105435080
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename QuicDataStream to QuicSpdyStream. No behavior change. QuicDataStream deals with HTTP2 (SPDY) headers. This is the extra behavior it introduces from the base ReliableQuicStream class. QuicSpdyStream is a more descriptive name, that clearly indicates this class is specifically for use with SPDY over QUIC. Merge internal change: 105435253 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -1074 lines) Patch
M net/net.gypi View 6 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_chromium_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/quic/quic_data_stream.h View 1 chunk +0 lines, -141 lines 0 comments Download
D net/quic/quic_data_stream.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D net/quic/quic_data_stream_test.cc View 1 chunk +0 lines, -595 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_reliable_client_stream.h View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_spdy_session.h View 2 chunks +6 lines, -8 lines 0 comments Download
M net/quic/quic_spdy_session.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + net/quic/quic_spdy_stream.h View 6 chunks +11 lines, -11 lines 0 comments Download
A + net/quic/quic_spdy_stream.cc View 6 chunks +17 lines, -18 lines 0 comments Download
A + net/quic/quic_spdy_stream_test.cc View 23 chunks +31 lines, -35 lines 0 comments Download
D net/quic/test_tools/quic_data_stream_peer.h View 1 chunk +0 lines, -29 lines 0 comments Download
D net/quic/test_tools/quic_data_stream_peer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +1 line, -1 line 0 comments Download
A + net/quic/test_tools/quic_spdy_stream_peer.h View 1 chunk +7 lines, -7 lines 0 comments Download
A + net/quic/test_tools/quic_spdy_stream_peer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1413713005 Patch 1

Dependent Patchsets:

Issue 1417683003 Patch 1

Messages

Total messages: 3 (1 generated)
alyssar1
5 years, 2 months ago (2015-10-21 16:13:34 UTC) #1
Ryan Hamilton
5 years, 2 months ago (2015-10-21 16:48:09 UTC) #2 
You're on a roll.

lgtm

Powered by Google App Engine
This is Rietveld 408576698