Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 1423453003: Remove non-incremental GC from memory reducer. (Closed)

Created:
5 years, 2 months ago by ulan
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove non-incremental GC from memory reducer. Incremental GC now finish quickly in background tabs too because they do not rely on idle notifications. BUG= Committed: https://crrev.com/5449c9848aac7ccf79f440a269bcd5d3865b0738 Cr-Commit-Position: refs/heads/master@{#31461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/heap/memory-reducer.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 2 months ago (2015-10-21 14:43:32 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-22 09:23:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423453003/1
5 years, 2 months ago (2015-10-22 09:24:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 10:23:45 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 10:24:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5449c9848aac7ccf79f440a269bcd5d3865b0738
Cr-Commit-Position: refs/heads/master@{#31461}

Powered by Google App Engine
This is Rietveld 408576698