Issue 14234023: Remove unused flush operation from Chromium audio.

Issue 14234023: Remove unused flush operation from Chromium audio. (Closed)

Created:
7 years, 8 months ago by miu

Modified:
7 years, 8 months ago

Reviewers:
Cris Neckar, tommi (sloooow) - chröme, DaleCurtis, scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused flush operation from Chromium audio. BUG=151051, 114697 TBR=cdn Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194401

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -78 lines)			Patch
M	content/browser/media/media_internals.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/media/audio_renderer_host.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/media/audio_renderer_host.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	content/common/media/audio_messages.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/renderer/media/audio_message_filter.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/media/audio_message_filter.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	media/audio/audio_output_controller.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	media/audio/audio_output_controller.cc	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	media/audio/audio_output_device.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/audio/audio_output_device.cc	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	media/audio/audio_output_device_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/audio_output_ipc.h	View	1 chunk	+0 lines, -5 lines	1 comment	Download
M	media/audio/null_audio_sink.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/audio/null_audio_sink.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/audio_renderer_mixer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/audio_renderer_mixer_input.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/audio_renderer_mixer_input.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/audio_renderer_mixer_input_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/audio_renderer_mixer_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	media/base/audio_renderer_sink.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/mock_audio_renderer_sink.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/audio_renderer_impl.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	webkit/media/webaudiosourceprovider_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/media/webaudiosourceprovider_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

miu

Trivial changes here to remove FlushStream IPC message and Flush() from AudioRendererSink interface. Actually, this ...

7 years, 8 months ago (2013-04-16 04:59:57 UTC) #1

tommi (sloooow) - chröme

lgtm! https://codereview.chromium.org/14234023/diff/1/media/audio/audio_output_ipc.h File media/audio/audio_output_ipc.h (left): https://codereview.chromium.org/14234023/diff/1/media/audio/audio_output_ipc.h#oldcode88 media/audio/audio_output_ipc.h:88: // TODO(tommi): This is currently neither implemented nor ...

7 years, 8 months ago (2013-04-16 08:15:11 UTC) #2

DaleCurtis

Thanks for... (•_•) ( •_•)>⌐■-■ (⌐■_■) Flushing this! YEAAAH! lgtm :)

7 years, 8 months ago (2013-04-16 16:51:29 UTC) #3

miu

Thanks all! :) cdn: Added you for OWNERs for trivial removal of message in content/common/media/audio_messages.h.

7 years, 8 months ago (2013-04-16 18:37:50 UTC) #5

miu

Committed patchset #1 manually as r194401 (presubmit successful).

7 years, 8 months ago (2013-04-16 18:39:53 UTC) #6

Cris Neckar

7 years, 8 months ago (2013-04-16 18:45:28 UTC) #7

Message was sent while issue was closed.

lgtm

While I appreciate that the change is trivial and removes a message, in the
future please do not commit in front of an OWNERs review for IPC changes. This
is a critical part of our overall strategy for protecting our users.

Expand Messages | Collapse Messages