Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 14234012: Enable RDP integration by default when the curtain mode is enabled by the policy. (Closed)

Created:
7 years, 8 months ago by alexeypa (please no reviews)
Modified:
7 years, 8 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Enable RDP integration by default when the curtain mode is enabled by the policy. Collateral changes: - The username matching policy is ignored for RDP sessions. BUG=137696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194443

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR feedback. #

Patch Set 3 : fixing a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M remoting/host/remoting_me2me_host.cc View 1 2 5 chunks +20 lines, -8 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 8 months ago (2013-04-12 18:53:09 UTC) #1
Wez
lgtm https://chromiumcodereview.appspot.com/14234012/diff/1/remoting/host/remoting_me2me_host.cc File remoting/host/remoting_me2me_host.cc (right): https://chromiumcodereview.appspot.com/14234012/diff/1/remoting/host/remoting_me2me_host.cc#newcode728 remoting/host/remoting_me2me_host.cc:728: // setting. Why? Requiring a specific ordering to ...
7 years, 8 months ago (2013-04-15 19:01:35 UTC) #2
alexeypa (please no reviews)
https://codereview.chromium.org/14234012/diff/1/remoting/host/remoting_me2me_host.cc File remoting/host/remoting_me2me_host.cc (right): https://codereview.chromium.org/14234012/diff/1/remoting/host/remoting_me2me_host.cc#newcode728 remoting/host/remoting_me2me_host.cc:728: // setting. On 2013/04/15 19:01:35, Wez wrote: > Why? ...
7 years, 8 months ago (2013-04-15 19:10:01 UTC) #3
alexeypa (please no reviews)
7 years, 8 months ago (2013-04-16 20:51:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r194443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698