Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 14234008: DevTools: Rename (program) to (native) in CPU profiler. (Closed)

Created:
7 years, 8 months ago by alph
Modified:
7 years, 1 month ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Rename (program) to (native) in CPU profiler. R=yurys@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/devtools/front_end/CPUProfileView.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
alph
PTAL
7 years, 8 months ago (2013-04-12 15:53:37 UTC) #1
yurys
lgtm
7 years, 8 months ago (2013-04-15 05:19:06 UTC) #2
pfeldman
7 years, 8 months ago (2013-04-15 05:34:28 UTC) #3
I would not land this. It does not make it any better from the understanding
point of view, but makes our existing docs and video clips explaining (program)
vs (idle) outdated. Please file bugs for user-visible changes and the ones
affecting docs and consult with devrels prior to applying changes.

Powered by Google App Engine
This is Rietveld 408576698