Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7711)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 14234002: [Android WebView] Never turn off viewport and fixed layout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove AwSettingsTest.testLoadWithOverviewModeViewportScale as it was using obsolete assumptions Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
index 54516111d5940ae6c6274d4f8dc0be2f50c02224..124ca582fde6ac8856fd6f43b75438cfa62f437b 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
@@ -149,19 +149,8 @@ public class AwSettings {
}
}
- /**
- * Set whether fixed layout mode is enabled. Must be updated together
- * with ContentSettings.UseWideViewport, which maps on WebSettings.viewport_enabled.
- */
public void setEnableFixedLayoutMode(final boolean enable) {
joth 2013/04/16 19:41:47 could add @deprecated, not worth a new patch set j
mnaganov (inactive) 2013/04/17 08:40:56 Done.
- // There is no need to lock, because the native code doesn't
- // read anything from the Java side.
- ThreadUtils.runOnUiThreadBlocking(new Runnable() {
- @Override
- public void run() {
- nativeSetEnableFixedLayoutMode(mNativeAwSettings, enable);
- }
- });
+ // No-op. Will be removed.
}
/**
@@ -246,8 +235,6 @@ public class AwSettings {
private native void nativeSetWebContents(int nativeAwSettings, int nativeWebContents);
- private native void nativeSetEnableFixedLayoutMode(int nativeAwSettings, boolean enable);
-
private native void nativeSetInitialPageScale(int nativeAwSettings, float scaleInPercent);
private native void nativeSetTextZoom(int nativeAwSettings, int textZoom);

Powered by Google App Engine
This is Rietveld 408576698