Issue 14234002: [Android WebView] Never turn off viewport and fixed layout

Issue 14234002: [Android WebView] Never turn off viewport and fixed layout (Closed)

Created:
7 years, 8 months ago by mnaganov (inactive)

Modified:
7 years, 8 months ago

Reviewers:
jamesr, aelias_OOO_until_Jul13, Jói, joth, benm (inactive), palmer

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, aelias_OOO_until_Jul13

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Never turn off viewport and fixed layout This is to avoid skipping "meta viewport" tag processing. For controlling wide viewport-related behavior, a corresponding WebSetting has been added into Blink. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194576

Patch Set 1 #

Patch Set 2 : Fixed failing test #

Patch Set 3 : Remove AwSettingsTest.testLoadWithOverviewModeViewportScale as it was using obsolete assumptions #

Total comments: 4

Patch Set 4 : Jonathan's comment addressed #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -115 lines)			Patch
M	android_webview/browser/renderer_host/aw_render_view_host_ext.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	android_webview/browser/renderer_host/aw_render_view_host_ext.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	android_webview/common/render_view_messages.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwSettings.java	View	1 2 3	2 chunks	+2 lines, -14 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnScaleChangedTest.java	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java	View	1 2	7 chunks	+2 lines, -40 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwTargetDensityDpiTest.java	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/ContentViewZoomTest.java	View		5 chunks	+0 lines, -5 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/native/aw_settings.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	android_webview/native/aw_settings.cc	View		4 chunks	+0 lines, -16 lines	0 comments	Download
M	android_webview/renderer/aw_render_view_ext.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	android_webview/renderer/aw_render_view_ext.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/browser/android/content_settings.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	content/public/common/common_param_traits_macros.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

Depends on the Blink change: https://codereview.chromium.org/13880019/

7 years, 8 months ago (2013-04-12 12:00:30 UTC) #1

mnaganov (inactive)

Need an OWNERS review, please take a look: jamesr@: webkit/glue joi@: content/public joth@: content/browser/android palmer@: ...

7 years, 8 months ago (2013-04-15 16:49:24 UTC) #4

joth

lgtm (saw Ben's review and didn't think you needed another aw owner) https://codereview.chromium.org/14234002/diff/15002/android_webview/java/src/org/chromium/android_webview/AwSettings.java File android_webview/java/src/org/chromium/android_webview/AwSettings.java ...

7 years, 8 months ago (2013-04-16 19:41:47 UTC) #9

mnaganov (inactive)

Thanks, everyone! https://codereview.chromium.org/14234002/diff/15002/android_webview/java/src/org/chromium/android_webview/AwSettings.java File android_webview/java/src/org/chromium/android_webview/AwSettings.java (right): https://codereview.chromium.org/14234002/diff/15002/android_webview/java/src/org/chromium/android_webview/AwSettings.java#newcode152 android_webview/java/src/org/chromium/android_webview/AwSettings.java:152: public void setEnableFixedLayoutMode(final boolean enable) { On ...

7 years, 8 months ago (2013-04-17 08:40:55 UTC) #10

mnaganov (inactive)

7 years, 8 months ago (2013-04-17 12:03:15 UTC) #11

Message was sent while issue was closed.

Committed patchset #4 manually as r194576 (presubmit successful).

Expand Messages | Collapse Messages