Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: src/utils.h

Issue 1423373004: MIPS: Fix unaligned read of bytecodes in interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecodes.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_UTILS_H_ 5 #ifndef V8_UTILS_H_
6 #define V8_UTILS_H_ 6 #define V8_UTILS_H_
7 7
8 #include <limits.h> 8 #include <limits.h>
9 #include <stdlib.h> 9 #include <stdlib.h>
10 #include <string.h> 10 #include <string.h>
(...skipping 1716 matching lines...) Expand 10 before | Expand all | Expand 10 after
1727 double d; 1727 double d;
1728 uint32_t u[2]; 1728 uint32_t u[2];
1729 } c; 1729 } c;
1730 c.d = value; 1730 c.d = value;
1731 uint32_t* ptr = reinterpret_cast<uint32_t*>(p); 1731 uint32_t* ptr = reinterpret_cast<uint32_t*>(p);
1732 *ptr = c.u[0]; 1732 *ptr = c.u[0];
1733 *(ptr + 1) = c.u[1]; 1733 *(ptr + 1) = c.u[1];
1734 #endif // V8_TARGET_ARCH_MIPS 1734 #endif // V8_TARGET_ARCH_MIPS
1735 } 1735 }
1736 1736
1737
1738 static inline uint16_t ReadUnalignedUInt16(const void* p) {
1739 #if !(V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64)
1740 return *reinterpret_cast<const uint16_t*>(p);
1741 #else // V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64
1742 // Prevent compiler from using load-half (mips lh) on (possibly)
1743 // non-16-bit aligned address.
1744 union conversion {
1745 uint16_t h;
1746 uint8_t b[2];
1747 } c;
1748 const uint8_t* ptr = reinterpret_cast<const uint8_t*>(p);
1749 c.b[0] = *ptr;
1750 c.b[1] = *(ptr + 1);
1751 return c.h;
1752 #endif // V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64
1753 }
1754
1755
1756 static inline void WriteUnalignedUInt16(void* p, uint16_t value) {
1757 #if !(V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64)
1758 *(reinterpret_cast<uint16_t*>(p)) = value;
1759 #else // V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64
1760 // Prevent compiler from using store-half (mips sh) on (possibly)
1761 // non-16-bit aligned address.
1762 union conversion {
1763 uint16_t h;
1764 uint8_t b[2];
1765 } c;
1766 c.h = value;
1767 uint8_t* ptr = reinterpret_cast<uint8_t*>(p);
1768 *ptr = c.b[0];
1769 *(ptr + 1) = c.b[1];
1770 #endif // V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64
1771 }
1772
1737 } // namespace internal 1773 } // namespace internal
1738 } // namespace v8 1774 } // namespace v8
1739 1775
1740 #endif // V8_UTILS_H_ 1776 #endif // V8_UTILS_H_
OLDNEW
« no previous file with comments | « src/interpreter/bytecodes.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698