MIPS: Fix unaligned read of bytecodes in interpreter.

src/interpreter/bytecodes.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecodes.h"
 
 #include "src/frames.h"
 #include "src/interpreter/bytecode-traits.h"
 
 namespace v8 {
@@ skipping 164 matching lines @@
          bytecode == Bytecode::kJumpIfTrueConstant ||
          bytecode == Bytecode::kJumpIfFalseConstant ||
          bytecode == Bytecode::kJumpIfToBooleanTrueConstant ||
          bytecode == Bytecode::kJumpIfToBooleanFalseConstant ||
          bytecode == Bytecode::kJumpIfNull ||
          bytecode == Bytecode::kJumpIfUndefinedConstant;
 }
 
 
 // static
-uint16_t Bytecodes::ShortOperandFromBytes(const uint8_t* bytes) {
-  return *reinterpret_cast<const uint16_t*>(bytes);
-}
-
-
-// static
-void Bytecodes::ShortOperandToBytes(uint16_t operand, uint8_t* bytes_out) {
-  *reinterpret_cast<uint16_t*>(bytes_out) = operand;
-}
-
-
-// static
 std::ostream& Bytecodes::Decode(std::ostream& os, const uint8_t* bytecode_start,
                                 int parameter_count) {
   Vector<char> buf = Vector<char>::New(50);
 
   Bytecode bytecode = Bytecodes::FromByte(bytecode_start[0]);
   int bytecode_size = Bytecodes::Size(bytecode);
 
   for (int i = 0; i < bytecode_size; i++) {
     SNPrintF(buf, "%02x ", bytecode_start[i]);
     os << buf.start();
@@ skipping 11 matching lines @@
     const uint8_t* operand_start =
         &bytecode_start[GetOperandOffset(bytecode, i)];
     switch (op_type) {
       case interpreter::OperandType::kCount8:
         os << "#" << static_cast<unsigned int>(*operand_start);
         break;
       case interpreter::OperandType::kIdx8:
         os << "[" << static_cast<unsigned int>(*operand_start) << "]";
         break;
       case interpreter::OperandType::kIdx16: {
-        os << "[" << Bytecodes::ShortOperandFromBytes(operand_start) << "]";
+        os << "[" << ReadUnalignedUInt16(operand_start) << "]";
         break;
       }
       case interpreter::OperandType::kImm8:
         os << "#" << static_cast<int>(static_cast<int8_t>(*operand_start));
         break;
       case interpreter::OperandType::kReg8: {
         Register reg = Register::FromOperand(*operand_start);
         if (reg.is_function_context()) {
           os << "<context>";
         } else if (reg.is_function_closure()) {
@@ skipping 112 matching lines @@
   }
   if (reg5.is_valid() && reg4.index() + 1 != reg5.index()) {
     return false;
   }
   return true;
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8