Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1423333002: Option support for `enableSuperMixins` (and more). (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Option support for `enableSuperMixins` (and more). * Adds language configuration support to `.analysis_options`: analyzer: language: enableSuperMixins: true (with validation). * Extracts context configuration out of `server` context_manager and into `analyzer` where it can be re-used by `analyzer_cli`. * Some general cleanup of option validation (with more to come!) R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/af7017e585f87ddc8dd0c149dcfbc586729eeb85

Patch Set 1 #

Patch Set 2 : Pubspec updates. #

Total comments: 6

Patch Set 3 : Review nits. #

Patch Set 4 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -74 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +1 line, -34 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/CHANGELOG.md View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_general.dart View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 1 2 9 chunks +194 lines, -32 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 6 chunks +92 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 1 month ago (2015-10-29 19:56:30 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1423333002/diff/20001/pkg/analysis_server/pubspec.yaml File pkg/analysis_server/pubspec.yaml (right): https://codereview.chromium.org/1423333002/diff/20001/pkg/analysis_server/pubspec.yaml#newcode9 pkg/analysis_server/pubspec.yaml:9: analyzer: '>=0.26.1+17 <0.27.0' Technically, we shouldn't increase the ...
5 years, 1 month ago (2015-10-29 20:24:04 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/1423333002/diff/20001/pkg/analysis_server/pubspec.yaml File pkg/analysis_server/pubspec.yaml (right): https://codereview.chromium.org/1423333002/diff/20001/pkg/analysis_server/pubspec.yaml#newcode9 pkg/analysis_server/pubspec.yaml:9: analyzer: '>=0.26.1+17 <0.27.0' On 2015/10/29 20:24:03, Brian Wilkerson ...
5 years, 1 month ago (2015-10-29 21:06:19 UTC) #4
pquitslund
5 years, 1 month ago (2015-10-29 21:11:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
af7017e585f87ddc8dd0c149dcfbc586729eeb85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698