Issue 14233006: Perform coverage blend with the dst in the shader when using a dst-reading xfermode.

Issue 14233006: Perform coverage blend with the dst in the shader when using a dst-reading xfermode. (Closed)

Created:
7 years, 8 months ago by bsalomon

Modified:
7 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Perform coverage blend with the dst in the shader when using a dst-reading xfermode. Committed: https://code.google.com/p/skia/source/detail?r=8762

Patch Set 2 : #

Total comments: 11

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -44 lines)			Patch
M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1	5 chunks	+68 lines, -21 lines	11 comments	Download
M	src/gpu/gl/GrGLProgramDesc.h	View		2 chunks	+29 lines, -10 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.cpp	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View		2 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp#newcode109 src/gpu/gl/GrGLProgram.cpp:109: case GrGLProgramDesc::kCombineWithDst_CoverageOutput: rm trailing /? https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp#newcode424 ...

7 years, 8 months ago (2013-04-18 22:02:03 UTC) #2

bsalomon

Committed patchset #2 manually as r8762 (presubmit successful).

7 years, 8 months ago (2013-04-19 13:14:49 UTC) #3

bsalomon

7 years, 8 months ago (2013-04-19 13:14:49 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp...
src/gpu/gl/GrGLProgram.cpp:109: case
GrGLProgramDesc::kCombineWithDst_CoverageOutput:
On 2013/04/18 22:02:03, robertphillips wrote:
> rm trailing /?

Done.

https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp...
src/gpu/gl/GrGLProgram.cpp:424: 
On 2013/04/18 22:02:03, robertphillips wrote:
> move into above namespace?

Done.

https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp...
src/gpu/gl/GrGLProgram.cpp:631: 
On 2013/04/18 22:02:03, robertphillips wrote:
> Add quotes ... "color * coverage"?

Done.

https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp...
src/gpu/gl/GrGLProgram.cpp:639: true);
On 2013/04/18 22:02:03, robertphillips wrote:
> "+(1-coverage)dst"?

Done.

https://codereview.chromium.org/14233006/diff/8001/src/gpu/gl/GrGLProgram.cpp...
src/gpu/gl/GrGLProgram.cpp:647: knownCoverageValue,
On 2013/04/18 22:02:03, robertphillips wrote:
> indent on true?

Done.

Expand Messages | Collapse Messages