Issue 1423283002: Fix debug compilation problems for gcc and 32 bit x86.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1423283002: Fix debug compilation problems for gcc and 32 bit x86. (Closed)

Created:
5 years, 1 month ago by fbarchard1

Modified:
5 years, 1 month ago

Reviewers:
harryjin, Daniel Bratell

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

Fix debug compilation problems for gcc and 32 bit x86. In some methods with 7 arguments gcc fails to find enough registers to compile the assembler code when compiling debug. Simplest solution is to skip the assembler version in debug of those particular functions (I422Alpha -> ARBG/ABGR) R=harryjin@google.com,bratell@opera.com BUG=libyuv:517 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/cdbdf5b7237e9c720e57c9b7a0c7211094feddd1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	include/libyuv/row.h	View		2 chunks	+10 lines, -2 lines	0 comments	Download
	M	source/row_gcc.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

fbarchard1

Committed patchset #1 (id:1) manually as cdbdf5b7237e9c720e57c9b7a0c7211094feddd1 (presubmit successful).

5 years, 1 month ago (2015-10-28 21:27:33 UTC) #2

Daniel Bratell

5 years, 1 month ago (2015-10-29 09:51:29 UTC) #4

Message was sent while issue was closed.

lgtm

I was never able to figure out where this format was used so I couldn't judge if
it would be noticed if it was slower.