Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1423233002: Centralize mojo_benchmark documentation. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Centralize mojo_benchmark documentation. fdsdfsdf sdfsd f sdf sd f sdf sd f sdf sd fsd fsw This patch removes the duplication between mojo_benchmark built-in help and mojo_benchmark.md documentation. The built-in help now points to the Markdown documentation. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/158137d99a91b98774f3b13787b8b9d6fcde4958 BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -54 lines) Patch
M mojo/devtools/common/docs/mojo_benchmark.md View 1 2 2 chunks +50 lines, -13 lines 0 comments Download
M mojo/devtools/common/mojo_benchmark View 1 chunk +2 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben, ptal.
5 years, 1 month ago (2015-10-28 14:09:43 UTC) #2
qsr
lgtm
5 years, 1 month ago (2015-10-28 15:01:04 UTC) #3
ppi
5 years, 1 month ago (2015-10-28 15:47:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
158137d99a91b98774f3b13787b8b9d6fcde4958 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698