Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142323003: Separate LineBreaker from RenderBlockLineLayout (Closed)

Created:
6 years, 11 months ago by Zoltan
Modified:
6 years, 11 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Separate LineBreaker from RenderBlockLineLayout As part of my RenderBlockLineLayout refactoring campaign (tracked under issue 316347) in this patch, I'm separating LineBreaker class into its own file. Since BreakingContext::handleEndOfLine() implementation is not inline, I moved it to BreakingContext.cpp in order to avoid linking errors. BUG=336293 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -220 lines) Patch
M Source/core/core.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 3 chunks +1 line, -169 lines 0 comments Download
A Source/core/rendering/line/BreakingContext.cpp View 1 chunk +73 lines, -0 lines 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 4 chunks +10 lines, -51 lines 0 comments Download
A Source/core/rendering/line/LineBreaker.h View 1 chunk +74 lines, -0 lines 0 comments Download
A Source/core/rendering/line/LineBreaker.cpp View 1 chunk +164 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
leviw_travelin_and_unemployed
lgtm
6 years, 11 months ago (2014-01-22 02:56:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/142323003/1
6 years, 11 months ago (2014-01-22 02:57:00 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18524
6 years, 11 months ago (2014-01-22 05:56:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/142323003/1
6 years, 11 months ago (2014-01-22 05:59:41 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8526
6 years, 11 months ago (2014-01-22 09:21:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/142323003/1
6 years, 11 months ago (2014-01-22 16:00:43 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 19:05:31 UTC) #7
Message was sent while issue was closed. 
Change committed as 165539

Powered by Google App Engine
This is Rietveld 408576698